Renaming streaming subscription to "subscribeToTopic" #1626
Conversation
|
@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk could you please take a look. I think this should be the final name for streaming subscription and it aligns with other SDKs nicely. @alicejgibbons @javier-aliaga @cicoyle could you also please take a look. Thank you 🙇 |
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
Can we create an alias for this so we dont break users. This functionality was backported, so I think its best to add an alias and mark the old as deprecated to be removed later.
artur-ciocanu
force-pushed
the
subscribe-to-topic
branch
from
c802e76 to
49a4b03
Compare
|
@cicoyle @salaboy and @javier-aliaga I have added aliases so we keep backward compatibility. |
|
@artur-ciocanu ok.. so there is a codecov gap there.. I promise you, I will fix the reports soon, but basically, you need to keep a couple of tests for the previous signature of the method. |
salaboy
left a comment
salaboy
left a comment
There was a problem hiding this comment.
LGTM, it just need the codecov report green
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
artur-ciocanu
force-pushed
the
subscribe-to-topic
branch
from
d0f605a to
4aea0fd
Compare
|
@artur-ciocanu done |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1626 +/- ##
============================================
+ Coverage 79.20% 79.23% +0.02%
- Complexity 2141 2142 +1
============================================
Files 234 234
Lines 6455 6457 +2
Branches 700 700
============================================
+ Hits 5113 5116 +3
+ Misses 990 988 -2
- Partials 352 353 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
Description
Renaming streaming subscription to "subscribeToTopic". This should align better with other Dapr SDKs and ensure that is more ergonomic.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: